Skip to content

Slimming down torchchat: Replace replace_attention_with_custom_sdpa_attention() with ET's implementation #1058

Open
@Jack-Khuu

Description

@Jack-Khuu

🚀 The feature, motivation and pitch

First surfaced in #1057, the replace_attention_with_custom_sdpa_attention function, used when exporting models in torchchat, can be replaced with the equivalent API provided in the Excecutorch https://github.com/pytorch/executorch/blob/main/examples/models/llama2/source_transformation/sdpa.py

Task: Swap the torchchat implementation with that of ExecuTorch's. Delete the then defunct code from torchchat

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    ExecuTorchIssues related to ExecuTorch installation, export, or build. Mobile uses separate tagsenhancementNew feature or requestgood first issueGood for newcomerstriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions