[BugFix] Fix broken unit tests caused by removal of torch.testng.assert_allclose #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 125 125
Lines 24280 24280
=======================================
Hits 21324 21324
Misses 2956 2956
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
vmoens
pushed a commit
that referenced
this pull request
Nov 4, 2022
vmoens
pushed a commit
that referenced
this pull request
Nov 4, 2022
vmoens
added a commit
that referenced
this pull request
Nov 4, 2022
* Distributed replay buffer prototype * Fixes comment issue * Makes ReplayBufferNode subclass TensorDictReplayBuffer * aha * amend * bf * Fixes print statements and removes redundant Collector arg * Fixes print statements and removes redundant Collector arg * amend * amend * Timing larger tensordict transfers over torch rpc using multiple storage types * init * amend * amend * update_ and make sure content is read * amend * amend * Fixes list storage arg * Moves benchmark to new top-level directory and adds note in documentation about speed up using MemmapTensor * Removes analysis.ipynb * Removes accidental edit to tensordict.py * Updates data.rst text * Removes redundant variable * Removes hack to get list read to work * replace assert_allclose with assert_close (#644) * Adds small note illustrating example usage Co-authored-by: Adi Goel <adityagoel@fb.com> Co-authored-by: vmoens <vincentmoens@gmail.com> Co-authored-by: sosmond <35877775+sosmond@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced torch.testing.assert_allclose with torch.testing.assert_close
Motivation and Context
close #643Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!