Skip to content

Commit 69d44f5

Browse files
authored
[Feature] Replace RewardClipping with SignTransform in Atari examples (#1870)
1 parent 6f6c896 commit 69d44f5

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

examples/a2c/utils_atari.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
NoopResetEnv,
2121
ParallelEnv,
2222
Resize,
23-
RewardClipping,
2423
RewardSum,
24+
SignTransform,
2525
StepCounter,
2626
ToTensorImage,
2727
TransformedEnv,
@@ -73,7 +73,7 @@ def make_parallel_env(env_name, num_envs, device, is_test=False):
7373
env.append_transform(RewardSum())
7474
env.append_transform(StepCounter(max_steps=4500))
7575
if not is_test:
76-
env.append_transform(RewardClipping(-1, 1))
76+
env.append_transform(SignTransform(in_keys=["reward"]))
7777
env.append_transform(DoubleToFloat())
7878
env.append_transform(VecNorm(in_keys=["pixels"]))
7979
return env

examples/dqn/utils_atari.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
GymEnv,
1515
NoopResetEnv,
1616
Resize,
17-
RewardClipping,
1817
RewardSum,
18+
SignTransform,
1919
StepCounter,
2020
ToTensorImage,
2121
TransformedEnv,
@@ -42,7 +42,7 @@ def make_env(env_name, frame_skip, device, is_test=False):
4242
env.append_transform(NoopResetEnv(noops=30, random=True))
4343
if not is_test:
4444
env.append_transform(EndOfLifeTransform())
45-
env.append_transform(RewardClipping(-1, 1))
45+
env.append_transform(SignTransform(in_keys=["reward"]))
4646
env.append_transform(ToTensorImage())
4747
env.append_transform(GrayScale())
4848
env.append_transform(Resize(84, 84))

examples/impala/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
GymEnv,
1717
NoopResetEnv,
1818
Resize,
19-
RewardClipping,
2019
RewardSum,
20+
SignTransform,
2121
StepCounter,
2222
ToTensorImage,
2323
TransformedEnv,
@@ -46,7 +46,7 @@ def make_env(env_name, device, is_test=False):
4646
env.append_transform(NoopResetEnv(noops=30, random=True))
4747
if not is_test:
4848
env.append_transform(EndOfLifeTransform())
49-
env.append_transform(RewardClipping(-1, 1))
49+
env.append_transform(SignTransform(in_keys=["reward"]))
5050
env.append_transform(ToTensorImage(from_int=False))
5151
env.append_transform(GrayScale())
5252
env.append_transform(Resize(84, 84))

examples/ppo/utils_atari.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
NoopResetEnv,
2020
ParallelEnv,
2121
Resize,
22-
RewardClipping,
2322
RewardSum,
23+
SignTransform,
2424
StepCounter,
2525
ToTensorImage,
2626
TransformedEnv,
@@ -71,7 +71,7 @@ def make_parallel_env(env_name, num_envs, device, is_test=False):
7171
env.append_transform(RewardSum())
7272
env.append_transform(StepCounter(max_steps=4500))
7373
if not is_test:
74-
env.append_transform(RewardClipping(-1, 1))
74+
env.append_transform(SignTransform(in_keys=["reward"]))
7575
env.append_transform(DoubleToFloat())
7676
env.append_transform(VecNorm(in_keys=["pixels"]))
7777
return env

0 commit comments

Comments
 (0)