Skip to content

Extract reusable portions of elu_kernel into header #149673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 20, 2025

Stack from ghstack (oldest at bottom):

Similar to #140425, we are making the implementation usable via header-only code sharing.

Review note: #62546 by @yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't.

Testing: existing correctness tests should cover.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Mar 20, 2025
Copy link

pytorch-bot bot commented Mar 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149673

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 42ed824 with merge base d072254 (image):

NEW FAILURE - The following job has failed:

  • linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test (gh)
    RuntimeError: cuDNN version incompatibility: PyTorch was compiled against (9, 8, 0) but found runtime version (9, 5, 1). PyTorch already comes bundled with cuDNN. One option to resolving this error is to ensure PyTorch can find the bundled cuDNN. one possibility is that there is a conflicting cuDNN in LD_LIBRARY_PATH.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Mar 20, 2025
Similar to #140425, we are making the implementation usable via header-only code sharing.

Review note: #62546 by yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't.

Testing: existing correctness tests should cover.

ghstack-source-id: 035a65f
Pull Request resolved: #149673
@swolchok swolchok added the topic: not user facing topic category label Mar 20, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 20, 2025
Similar to #140425, we are making the implementation usable via header-only code sharing.

Review note: #62546 by yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't.

Testing: existing correctness tests should cover.

ghstack-source-id: 53ddb9d
Pull Request resolved: #149673
@swolchok
Copy link
Contributor Author

swolchok commented Mar 20, 2025

some tests failed, complaining about accuracy. expm1(x) is supposed to be more accurate than exp(x) - 1 when x is close to zero, so I'm changing tests.

@swolchok
Copy link
Contributor Author

note that this PR uses ghstack so its not based on main for some reason, guess I'll have to use ghstack land? first time using ghstack with pytorch/pytorch

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 21, 2025
Similar to #140425, we are making the implementation usable via header-only code sharing.

Review note: #62546 by yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't.

Testing: existing correctness tests should cover.

ghstack-source-id: d44fc1b
Pull Request resolved: #149673
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 21, 2025
Similar to #140425, we are making the implementation usable via header-only code sharing.

Review note: #62546 by yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't.

Testing: existing correctness tests should cover.

ghstack-source-id: 6234a67
Pull Request resolved: #149673
@swolchok
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 21, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team Raised by workflow job

@swolchok
Copy link
Contributor Author

failure seems unrelated, @izaitsevfb agreed, landing

@swolchok
Copy link
Contributor Author

@pytorchbot merge -f

Copy link

pytorch-bot bot commented Mar 21, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@swolchok
Copy link
Contributor Author

@pytorchbot merge -f "failure seems unrelated, @izaitsevfb agreed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

swolchok added a commit to pytorch/executorch that referenced this pull request Mar 22, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: e75efc9
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 22c9734
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 22c9734
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: bc31e5d
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Mar 26, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: fe46a4f
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Mar 27, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 50f2d19
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Mar 27, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 0a1d499
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Mar 28, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 5bd376e
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Apr 2, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: fa4b18e
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Apr 3, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: f198f69
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit to pytorch/executorch that referenced this pull request Apr 4, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 38caa4d
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
Similar to pytorch#140425, we are making the implementation usable via header-only code sharing.

Review note: pytorch#62546 by @yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't.

Testing: existing correctness tests should cover.

Pull Request resolved: pytorch#149673
Approved by: https://github.com/cyyever, https://github.com/Skylion007
@github-actions github-actions bot deleted the gh/swolchok/724/head branch April 27, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants