-
Notifications
You must be signed in to change notification settings - Fork 24.1k
Extract reusable portions of elu_kernel into header #149673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149673
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 42ed824 with merge base d072254 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Similar to #140425, we are making the implementation usable via header-only code sharing. Review note: #62546 by yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't. Testing: existing correctness tests should cover. ghstack-source-id: 035a65f Pull Request resolved: #149673
Similar to #140425, we are making the implementation usable via header-only code sharing. Review note: #62546 by yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't. Testing: existing correctness tests should cover. ghstack-source-id: 53ddb9d Pull Request resolved: #149673
some tests failed, complaining about accuracy. |
note that this PR uses ghstack so its not based on main for some reason, guess I'll have to use ghstack land? first time using ghstack with pytorch/pytorch |
Similar to #140425, we are making the implementation usable via header-only code sharing. Review note: #62546 by yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't. Testing: existing correctness tests should cover. ghstack-source-id: d44fc1b Pull Request resolved: #149673
Similar to #140425, we are making the implementation usable via header-only code sharing. Review note: #62546 by yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't. Testing: existing correctness tests should cover. ghstack-source-id: 6234a67 Pull Request resolved: #149673
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test Details for Dev Infra teamRaised by workflow job |
failure seems unrelated, @izaitsevfb agreed, landing |
@pytorchbot merge -f |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot merge -f "failure seems unrelated, @izaitsevfb agreed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: e75efc9 ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: 22c9734 ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: 22c9734 ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: bc31e5d ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: fe46a4f ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: 50f2d19 ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: 0a1d499 ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: 5bd376e ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: fa4b18e ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: f198f69 ghstack-comment-id: 2744722101 Pull Request resolved: #9521
This uses PyTorch code sharing, so we'll need a pin bump to pick up pytorch/pytorch#149673 (and pytorch/pytorch#149684 and, when it lands, pytorch/pytorch#149780). ghstack-source-id: 38caa4d ghstack-comment-id: 2744722101 Pull Request resolved: #9521
Similar to pytorch#140425, we are making the implementation usable via header-only code sharing. Review note: pytorch#62546 by @yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't. Testing: existing correctness tests should cover. Pull Request resolved: pytorch#149673 Approved by: https://github.com/cyyever, https://github.com/Skylion007
Stack from ghstack (oldest at bottom):
Similar to #140425, we are making the implementation usable via header-only code sharing.
Review note: #62546 by @yanbing-j removed expm1 usage from this path. I don't know why and expm1 should be more efficient, so I've put it back. Please let me know if there is a good reason I shouldn't.
Testing: existing correctness tests should cover.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10