With pytest8.2.0 or later, test cases under test/distributed/ execute will meet issue "object has no attribute 'runTest'. Did you mean: 'run_test'"

[hongfeng2013]

🐛 Describe the bug

This information is from "docs.pytest.org"
In pytest 8.2.0: #12089: pytest now requires that unittest.TestCase subclasses can be instantiated freely using MyTestCase('runTest').

1. With this pytest-8.2.1 version, when I execute: pytest -v test_c10d_nccl.py::NCCLTraceTest
   

2. With pytest-8.1.1 version, when I execute: pytest -v test_c10d_nccl.py::NCCLTraceTest
   

The related source code, torch/testing/_internal/common_distributed.py:

def __init__(self, method_name: str = "runTest") -> None:
        super().__init__(method_name)
        fn = getattr(self, method_name)
        setattr(self, method_name, self.join_or_run(fn))

Versions

Any pytorch version

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k

[kwen2501]

Hi thanks for reporting.
Do you mean that with the new pytest version, one cannot rely on dynamically setting attr, but would need to define an runTest method?

[hongfeng2013]

Hi,
Thank you for your attention to this issue.

This information is from the pytest change log, the link is: https://docs.pytest.org/en/8.2.x/changelog.html
pytest 8.2.0 (2024-04-27)
Breaking Changes
#12089: pytest now requires that unittest.TestCase subclasses can be instantiated freely using MyTestCase('runTest').

If the class doesn’t allow this, you may see an error during collection such as AttributeError: 'MyTestCase' object has no attribute 'runTest'.

Classes which do not override init, or do not access the test method in init using getattr or similar, are unaffected.

Classes which do should take care to not crash when "runTest" is given, as is shown in unittest.TestCases’s implementation. Alternatively, consider using setUp instead of init.