Skip to content

Commit 6fefc52

Browse files
huydhnpytorchmergebot
authored andcommitted
Set py3.x build-environment name consistently (#122247)
#122157 checks for the Python version using `"$BUILD_ENVIRONMENT" != *py3.8*`, but some build environment uses a different style with `py3_8` instead causing numpy 2.x to be installed there wrongly, i.e. https://hud.pytorch.org/pytorch/pytorch/commit/03b987fe3fa93f398c0af5b40e512950c39a7cb6 Pull Request resolved: #122247 Approved by: https://github.com/malfet
1 parent 6c659bb commit 6fefc52

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/inductor.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ jobs:
111111
name: linux-jammy-cpu-py3.8-gcc11-inductor
112112
uses: ./.github/workflows/_linux-build.yml
113113
with:
114-
build-environment: linux-jammy-py3_8-gcc11-build
114+
build-environment: linux-jammy-py3.8-gcc11-build
115115
docker-image-name: pytorch-linux-jammy-py3.8-gcc11-inductor-benchmarks
116116
test-matrix: |
117117
{ include: [
@@ -135,7 +135,7 @@ jobs:
135135
uses: ./.github/workflows/_linux-test.yml
136136
needs: linux-jammy-cpu-py3_8-gcc11-inductor-build
137137
with:
138-
build-environment: linux-jammy-py3_8-gcc11-build
138+
build-environment: linux-jammy-py3.8-gcc11-build
139139
docker-image: ${{ needs.linux-jammy-cpu-py3_8-gcc11-inductor-build.outputs.docker-image }}
140140
test-matrix: ${{ needs.linux-jammy-cpu-py3_8-gcc11-inductor-build.outputs.test-matrix }}
141141
secrets:

.github/workflows/pull.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ jobs:
319319
name: linux-focal-py3_8-clang9-xla
320320
uses: ./.github/workflows/_linux-build.yml
321321
with:
322-
build-environment: linux-focal-py3_8-clang9-xla
322+
build-environment: linux-focal-py3.8-clang9-xla
323323
docker-image-name: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/xla_base:v1.1-lite
324324
test-matrix: |
325325
{ include: [
@@ -331,7 +331,7 @@ jobs:
331331
uses: ./.github/workflows/_linux-test.yml
332332
needs: linux-focal-py3_8-clang9-xla-build
333333
with:
334-
build-environment: linux-focal-py3_8-clang9-xla
334+
build-environment: linux-focal-py3.8-clang9-xla
335335
docker-image: ${{ needs.linux-focal-py3_8-clang9-xla-build.outputs.docker-image }}
336336
test-matrix: ${{ needs.linux-focal-py3_8-clang9-xla-build.outputs.test-matrix }}
337337

0 commit comments

Comments
 (0)