Fixed Opacus's Runtime error with an empty batch (issue 612) #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53733081 |
EnayatUllah
added a commit
to EnayatUllah/opacus
that referenced
this pull request
Feb 16, 2024
…#631) Summary: In case of an empty batch, in the ```clip_and_accumulate``` function, the ```per_sample_clip_factor``` variable is set to a tensor of size 0. However, the device was not specified, which throws a runtime error. Added it. Differential Revision: D53733081
EnayatUllah
force-pushed
the
export-D53733081
branch
from
b165af7
to
bc1b886
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53733081 |
EnayatUllah
added a commit
to EnayatUllah/opacus
that referenced
this pull request
Feb 16, 2024
…#631) Summary: In case of an empty batch, in the ```clip_and_accumulate``` function, the ```per_sample_clip_factor``` variable is set to a tensor of size 0. However, the device was not specified, which throws a runtime error. Added it. Differential Revision: D53733081
EnayatUllah
force-pushed
the
export-D53733081
branch
from
bc1b886
to
15de443
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53733081 |
EnayatUllah
force-pushed
the
export-D53733081
branch
from
15de443
to
fa7b0d1
Compare
EnayatUllah
added a commit
to EnayatUllah/opacus
that referenced
this pull request
Feb 16, 2024
…#631) Summary: In case of an empty batch, in the ```clip_and_accumulate``` function, the ```per_sample_clip_factor``` variable is set to a tensor of size 0. However, the device was not specified, which throws a runtime error. Added it. Differential Revision: D53733081
|
This pull request was exported from Phabricator. Differential Revision: D53733081 |
…#631) Summary: In case of an empty batch, in the ```clip_and_accumulate``` function, the ```per_sample_clip_factor``` variable is set to a tensor of size 0. However, the device was not specified, which throws a runtime error. Added it. Differential Revision: D53733081
EnayatUllah
force-pushed
the
export-D53733081
branch
from
fa7b0d1
to
52d9797
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53733081 |
|
This pull request has been merged in ac639af. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In case of an empty batch, in the
clip_and_accumulatefunction, theper_sample_clip_factorvariable is set to a tensor of size 0. However, the device was not specified, which throws a runtime error. Added it.Differential Revision: D53733081