Throws an error when params in optimizer are not the same as that of module's in make_private
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
deepakagrawal
pushed a commit
to deepakagrawal/opacus
that referenced
this pull request
Jun 17, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Differential Revision: D37163873 fbshipit-source-id: 73a8c3b5afa1b1e080c6fe7ed77a4a6130c9fdf9
deepakagrawal
force-pushed
the
export-D37163873
branch
from
2be899b
to
99b03c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
deepakagrawal
pushed a commit
to deepakagrawal/opacus
that referenced
this pull request
Jun 17, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Differential Revision: D37163873 fbshipit-source-id: 8e25fa1738f08c5aa52f856023f72948164d6f0e
deepakagrawal
force-pushed
the
export-D37163873
branch
from
99b03c8
to
bdaab58
Compare
|
Thanks for adding the tests @deepakagrawal! Please also fix the lint failure and it is good to go after that :) |
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
deepakagrawal
pushed a commit
to deepakagrawal/opacus
that referenced
this pull request
Jun 17, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Differential Revision: D37163873 fbshipit-source-id: 96cd2bc3ce9a136e450d5927b602b82f8072af9c
deepakagrawal
force-pushed
the
export-D37163873
branch
from
bdaab58
to
3ed0b5d
Compare
deepakagrawal
pushed a commit
to deepakagrawal/opacus
that referenced
this pull request
Jun 17, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Differential Revision: D37163873 fbshipit-source-id: de7e96f02d0d3d711032c9d77e22ae48bb06f0bb
deepakagrawal
force-pushed
the
export-D37163873
branch
from
3ed0b5d
to
f9e746c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
deepakagrawal
pushed a commit
to deepakagrawal/opacus
that referenced
this pull request
Jun 17, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Differential Revision: D37163873 fbshipit-source-id: 5098af6123c4280119276bd7a7d0310118fc8914
deepakagrawal
force-pushed
the
export-D37163873
branch
from
f9e746c
to
ef58c21
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
deepakagrawal
pushed a commit
to deepakagrawal/opacus
that referenced
this pull request
Jun 17, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Differential Revision: D37163873 fbshipit-source-id: b4e27d4b7879c5804424b2d1b18921409073d267
deepakagrawal
force-pushed
the
export-D37163873
branch
from
ef58c21
to
8ca0b41
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
deepakagrawal
pushed a commit
to deepakagrawal/opacus
that referenced
this pull request
Jun 17, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Differential Revision: D37163873 fbshipit-source-id: cf2d89ae50ed7387406a0cea362994fb975d2db1
deepakagrawal
force-pushed
the
export-D37163873
branch
from
8ca0b41
to
7b1ad07
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
deepakagrawal
pushed a commit
to deepakagrawal/opacus
that referenced
this pull request
Jun 17, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Differential Revision: D37163873 fbshipit-source-id: b2f9d3d6e4efda335ff47e110593d96b19188094
deepakagrawal
force-pushed
the
export-D37163873
branch
from
7b1ad07
to
7fcd0e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
|
@karthikprasad can you please check the errors. I think they are not related to the changes I made. I fixed the lint failure. |
karthikprasad
approved these changes
Jun 20, 2022
…module's in `make_private` (pytorch#439) Summary: Pull Request resolved: pytorch#439 Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters" Reviewed By: karthikprasad Differential Revision: D37163873 fbshipit-source-id: daca6711570dd7006c1aaf7f757c3d81dbaaeda1
|
This pull request was exported from Phabricator. Differential Revision: D37163873 |
deepakagrawal
force-pushed
the
export-D37163873
branch
from
7fcd0e4
to
baa9502
Compare
|
@karthikprasad pushed the latest commit to github. I will land the diff as well. Can you please merge this on github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters"
Differential Revision: D37163873