Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix opacus nn.functional import (#901) #426

Closed
wants to merge 1 commit into from

Conversation

ngimel
Copy link

@ngimel ngimel commented May 5, 2022

Summary:
X-link: pytorch/benchmark#901
Additional context: this change is necessitated by pytorch/pytorch#73434, that replaces import torch.nn.functional as F with import torch.nn.functional, causing from torch.functional import F in opacus to no longer be valid.

per title

Differential Revision: D36172316

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels May 5, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36172316

@karthikprasad karthikprasad self-requested a review May 5, 2022 18:52
Copy link
Contributor

@karthikprasad karthikprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

ngimel pushed a commit to ngimel/opacus that referenced this pull request May 5, 2022
Summary:
Pull Request resolved: pytorch#426

X-link: pytorch/benchmark#901

per title

Reviewed By: karthikprasad

Differential Revision: D36172316

fbshipit-source-id: d22dc8e3b6e0a3670905c7c4f9307e6df08e41db
@ngimel ngimel force-pushed the export-D36172316 branch from d73c56c to 1372c54 Compare May 5, 2022 19:07
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36172316

Summary:
Pull Request resolved: pytorch#426

X-link: pytorch/benchmark#901

per title

Reviewed By: karthikprasad, anjali411

Differential Revision: D36172316

fbshipit-source-id: aaeb821700a831defac7b0760d3e6f12b3247753
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36172316

@ngimel ngimel force-pushed the export-D36172316 branch from 1372c54 to 42ba861 Compare May 5, 2022 19:52
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request May 5, 2022
Summary:
X-link: pytorch/opacus#426

Pull Request resolved: #901

per title

Reviewed By: malfet, karthikprasad, anjali411

Differential Revision: D36172316

fbshipit-source-id: c9e665e57a69c8e87a6f5a0a902693ff90d99943
xuzhao9 pushed a commit to pytorch/benchmark that referenced this pull request May 6, 2022
Summary:
X-link: pytorch/opacus#426

Pull Request resolved: #901

per title

Reviewed By: malfet, karthikprasad, anjali411

Differential Revision: D36172316

fbshipit-source-id: c9e665e57a69c8e87a6f5a0a902693ff90d99943
xuzhao9 pushed a commit to pytorch/benchmark that referenced this pull request May 6, 2022
Summary:
X-link: pytorch/opacus#426

Pull Request resolved: #901

per title

Reviewed By: malfet, karthikprasad, anjali411

Differential Revision: D36172316

fbshipit-source-id: c9e665e57a69c8e87a6f5a0a902693ff90d99943
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request May 11, 2022
Summary:
Recently CI is broken because fairseq updated their code to add xformers dependencies.
We should pin the fairseq verison to 0.11.0 to prevent future code breakage.

Also, add constraints to the opacus package because of pytorch/opacus#426

Pull Request resolved: #902

Reviewed By: erichan1

Differential Revision: D36237766

Pulled By: xuzhao9

fbshipit-source-id: 3e1f961f3d3ce0a393663e30d6ea712bff20204c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants