fix opacus nn.functional import (#901) #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36172316 |
ngimel
pushed a commit
to ngimel/opacus
that referenced
this pull request
May 5, 2022
Summary: Pull Request resolved: pytorch#426 X-link: pytorch/benchmark#901 per title Reviewed By: karthikprasad Differential Revision: D36172316 fbshipit-source-id: d22dc8e3b6e0a3670905c7c4f9307e6df08e41db
|
This pull request was exported from Phabricator. Differential Revision: D36172316 |
Summary: Pull Request resolved: pytorch#426 X-link: pytorch/benchmark#901 per title Reviewed By: karthikprasad, anjali411 Differential Revision: D36172316 fbshipit-source-id: aaeb821700a831defac7b0760d3e6f12b3247753
|
This pull request was exported from Phabricator. Differential Revision: D36172316 |
malfet
approved these changes
May 5, 2022
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
May 5, 2022
Summary: X-link: pytorch/opacus#426 Pull Request resolved: #901 per title Reviewed By: malfet, karthikprasad, anjali411 Differential Revision: D36172316 fbshipit-source-id: c9e665e57a69c8e87a6f5a0a902693ff90d99943
xuzhao9
pushed a commit
to pytorch/benchmark
that referenced
this pull request
May 6, 2022
Summary: X-link: pytorch/opacus#426 Pull Request resolved: #901 per title Reviewed By: malfet, karthikprasad, anjali411 Differential Revision: D36172316 fbshipit-source-id: c9e665e57a69c8e87a6f5a0a902693ff90d99943
xuzhao9
pushed a commit
to pytorch/benchmark
that referenced
this pull request
May 6, 2022
Summary: X-link: pytorch/opacus#426 Pull Request resolved: #901 per title Reviewed By: malfet, karthikprasad, anjali411 Differential Revision: D36172316 fbshipit-source-id: c9e665e57a69c8e87a6f5a0a902693ff90d99943
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
May 11, 2022
Summary: Recently CI is broken because fairseq updated their code to add xformers dependencies. We should pin the fairseq verison to 0.11.0 to prevent future code breakage. Also, add constraints to the opacus package because of pytorch/opacus#426 Pull Request resolved: #902 Reviewed By: erichan1 Differential Revision: D36237766 Pulled By: xuzhao9 fbshipit-source-id: 3e1f961f3d3ce0a393663e30d6ea712bff20204c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/benchmark#901
Additional context: this change is necessitated by pytorch/pytorch#73434, that replaces
import torch.nn.functional as Fwithimport torch.nn.functional, causingfrom torch.functional import Fin opacus to no longer be valid.per title
Differential Revision: D36172316