fix(batch_memory_manager): Ensures split_idxs use native python types. #410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
Ensures that
split_idxs
are passed forward using native Python types instead of Numpy-based types. (Issue #406)How Has This Been Tested (if it applies)
np.array_split
asserts that the output will be a list of Numpy arrays, with Numpy-based types (such as np.int64, np.float32, etc).Unfortunately, there might be a chance that external resources (huggingface/datasets) use Python-native types and thus, the list of arrays needs to be mapped to a list of lists (which uses Python native types). Also, we need to traverse the list to perform such an operation.
Checklist