Warn and ignore "drop_last" when set in DPDataLoader #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34197820 |
There was a problem hiding this comment.
Hi @gautham-kollu , thanks for taking this up. I just added a couple of nits, looks good otherwise. Happy to approve after the changes :)
opacus/data_loader.py
Outdated
| @@ -143,13 +144,15 @@ def __init__( | |||
| if collate_fn is None: | |||
| collate_fn = default_collate | |||
|
|
|||
| if drop_last: | |||
| warnings.warn("Ignoring drop_last as it is not compatible with DPDataLoader.") | |||
opacus/tests/dpdataloader_test.py
Outdated
|
|
||
| dataset = TensorDataset(x) | ||
| data_loader = DataLoader(dataset, drop_last=True) | ||
| dp_data_loader = DPDataLoader.from_data_loader(data_loader) |
There was a problem hiding this comment.
nit: pacify linter
Suggested change
| dp_data_loader = DPDataLoader.from_data_loader(data_loader) | |
| _ = DPDataLoader.from_data_loader(data_loader) |
gautham-kollu
added a commit
to gautham-kollu/opacus
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: pytorch#357 Add a warning to show "drop_last" is being ignored and is not compatible with DPDataLoader Differential Revision: D34197820 fbshipit-source-id: 6e7d1ba69c6018a4219bc9e8640c61fac806f8cf
gautham-kollu
force-pushed
the
export-D34197820
branch
from
23d1f7c to
5a11b36
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34197820 |
Summary: Pull Request resolved: pytorch#357 Add a warning to show "drop_last" is being ignored and is not compatible with DPDataLoader Differential Revision: D34197820 fbshipit-source-id: 1ff0b0ac4a0b4b6248e6b95e532a928e0ef0be02
gautham-kollu
force-pushed
the
export-D34197820
branch
from
5a11b36 to
40c6219
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34197820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add a warning to show "drop_last" is being ignored and is not compatible with DPDataLoader
Differential Revision: D34197820