Fix: Passing through defaults in DPOptimizer
#329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adding `defaults` to DPOptimizer to match Pytorch Optimizer Differential Revision: D33634214 fbshipit-source-id: da2f8797da05860be68b90f99e181d6d94200755
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33634214 |
|
@alexandresablayrolles Could you please add more comments: why we need to match UPD: Found the original issue, updated the description. |
romovpa
changed the title
defaults to DPOptimizer to match Pytorch Optimizerdefaults in DPOptimizer
romovpa
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Described in #322. The code using schedules can be broken because DPOptimizer doesn't have
.defaultsfield. For example, when using NAdam, schedulers with cycle_momentum=True.Solution
As suggested by @gkaissis, just passing through the
defaultsfield to DPOptimizer.Differential Revision: D33634214