Fix: Passing through defaults
in DPOptimizer
#329
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Described in #322. The code using schedules can be broken because DPOptimizer doesn't have
.defaults
field. For example, when using NAdam, schedulers with cycle_momentum=True.Solution
As suggested by @gkaissis, just passing through the
defaults
field to DPOptimizer.Differential Revision: D33634214