-
-
Notifications
You must be signed in to change notification settings - Fork 653
Refactor EpochMetric
and make it idempotent
#2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor EpochMetric
and make it idempotent
#2800
Conversation
Seems like there is a bug here: ignite/ignite/metrics/epoch_metric.py Lines 148 to 152 in 7c8d801
Thanks for catching that @sadra-barikbin ! |
d3779e8
to
1f05f23
Compare
10d7542
to
af77ead
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @sadra-barikbin
By adding an assertion to check recomputing metric does not change its result,
_test_distrib_integration
fails.