Skip to content

[BC-breaking] Fix ssim run on cuda 2532 #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
May 4, 2022

Conversation

sadra-barikbin
Copy link
Collaborator

@sadra-barikbin sadra-barikbin commented May 4, 2022

Fixes #2532

Description:

  • Recoded update/compute methods : [BC-breaking] compute now return float instead of Tensor
  • Fix for master to be able to run on cuda

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

sadra-barikbin and others added 30 commits January 22, 2022 23:03
@github-actions github-actions bot added the module: metrics Metrics module label May 4, 2022
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 vfdev-5 merged commit 315b6b9 into pytorch:master May 4, 2022
@vfdev-5 vfdev-5 changed the title Fix ssim run on cuda 2532 [BC-breaking] Fix ssim run on cuda 2532 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: metrics Metrics module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSIM update does not work for the last batch (if batch size is different)
2 participants