Skip to content

Commit 42c4d29

Browse files
avinashsharma080Avinash Sharmavfdev-5avinash080
authored
Added python 3.12 dependency in CI (#3219)
* Fix for v5 labeler * Fix for v5 labeler * test for v5 fix * testing new pr labeler workflow * testing new pr labeler workflow * testing new pr labeler workflow * renamed pr-labeler-config to labeler for v5 * Update triage.yml * Update triage.yml * Update triage.yml * Update triage.yml * Rename labeler.yml to pr-labeler-config.yml * Update triage.yml * Update triage.yml * added python 3.12 dependency in CI * added python 3.12 dependency in CI * Delete .vscode/settings.json * Update requirements-dev.txt --------- Co-authored-by: Avinash Sharma <avi@Avinashs-MacBook-Pro-2.local> Co-authored-by: vfdev <vfdev.5@gmail.com> Co-authored-by: avinashsharma080 <avinashsharma6174@gmail.com>
1 parent a7246e1 commit 42c4d29

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/unit-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
fail-fast: false
4141
matrix:
4242
os: [ubuntu-latest]
43-
python-version: [3.8, 3.9, "3.10", "3.11"]
43+
python-version: ["3.8", "3.9", "3.10", "3.11","3.12"]
4444
pytorch-channel: [pytorch, pytorch-nightly]
4545
include:
4646
# includes a single build on windows

examples/mnist/mnist.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def log_validation_results(engine):
9696

9797
@trainer.on(Events.EPOCH_COMPLETED | Events.COMPLETED)
9898
def log_time(engine):
99-
tqdm.write(f"{trainer.last_event_name.name} took { trainer.state.times[trainer.last_event_name.name]} seconds")
99+
tqdm.write(f"{trainer.last_event_name.name} took {trainer.state.times[trainer.last_event_name.name]} seconds")
100100

101101
trainer.run(train_loader, max_epochs=epochs)
102102
pbar.close()

requirements-dev.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ pynvml
2323
clearml
2424
scikit-image
2525
py-rouge
26-
nltk
26+
# temporary fix for python=3.12 and v3.8.1
27+
# nltk
28+
git+https://github.com/nltk/nltk
2729
# Examples dependencies
2830
pandas
2931
gymnasium

0 commit comments

Comments
 (0)