[ET][Testing] Build test_backend_compiler_lib when testing is on #9953
Conversation
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9953
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit da17865 with merge base ae2d822 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @@ -109,11 +107,7 @@ def forward(self, x): | |||
| torch.allclose(model_outputs[0], expected_res, atol=1e-03, rtol=1e-03) | |||
| ) | |||
|
|
|||
| @given( | |||
| unlift=st.booleans(), # verify both lifted and unlifted graph | |||
There was a problem hiding this comment.
Any specific reason we don't test lifted vs unlifted?
There was a problem hiding this comment.
these variables aren't actually being used, I'm not sure why it's not being tested, but it wasn't being tested to begin with, and pytest complains about that, so i'm just cleaning up here.
There was a problem hiding this comment.
Oh hmm, how did you find out they are not tested?
There was a problem hiding this comment.
unlift variable isn't used in the test body. pytest complains about that and says given is useless if that's the case.
There was a problem hiding this comment.
Ah looks like it was deleted in #3169
There was a problem hiding this comment.
Ah I understand now, it was used when exported program decided to lift all the params. It's not needed now params are all lifted anyway
|
Looks CI passes! Thanks for sharing me the issue! |
…orch#9953) Adding test_backend_compiler_lib to pybinds when tests are on. This allows us to run some more backend tests in the OSS build. There were a couple of other test files that weren't able to be enabled: ``` --ignore=exir/backend/test/test_backends.py --ignore=exir/backend/test/test_backends_lifted.py --ignore=exir/backend/test/test_partitioner.py ``` This was because they were doing some torch.ops.load_library("buck_path") or there was another backend ExecutorBackend that was required. I'll limit the changes of this PR to just be enablement of the BackendWithCompilerLibDemo backend.
Adding test_backend_compiler_lib to pybinds when tests are on. This allows us to run some more backend tests in the OSS build. There were a couple of other test files that weren't able to be enabled:
This was because they were doing some torch.ops.load_library("buck_path") or there was another backend ExecutorBackend that was required. I'll limit the changes of this PR to just be enablement of the BackendWithCompilerLibDemo backend.