[Release 0.6] update torchao pin #9947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9947
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9c9bf25 with merge base 52b4483 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
metascroy
added
module: build/install
metascroy
commented
Apr 7, 2025
| @@ -61,7 +61,7 @@ jobs: | |||
| post-script: ${{ matrix.post-script }} | |||
| package-name: ${{ matrix.package-name }} | |||
| # Meta's macOS runners do not have Xcode, so use GitHub's runners. | |||
| runner-type: macos-latest-xlarge | |||
| runner-type: macos-15-xlarge | |||
There was a problem hiding this comment.
torchao does not build on < macos15 due to "std::aligned_alloc" not being implemented until macos15.
atalman
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Apr 8, 2025
We are trying to bump the torchao pin in ExecuTorch, but CI jobs fail: pytorch/executorch#9947. In particular this job fails: https://github.com/pytorch/executorch/actions/runs/14321828652/job/40140080161?pr=9947 The root cause is "/Users/runner/work/executorch/executorch/pytorch/executorch/third-party/ao/torchao/experimental/../../torchao/experimental/ops/memory.h:22:34: error: 'aligned_alloc' is only available on macOS 10.15 or newer [-Werror,-Wunguarded-availability-new]" This is because the test infra defines the "export MACOSX_DEPLOYMENT_TARGET=10.13".
mergennachin
approved these changes
Apr 8, 2025
mergennachin
reviewed
Apr 8, 2025
pyproject.toml
Outdated
| @@ -66,6 +66,8 @@ dependencies=[ | |||
| "ruamel.yaml", | |||
| "sympy", | |||
| "tabulate", | |||
| # Keep this version in sync with: third-party/ao pin | |||
| "torchao==0.10.0", | |||
There was a problem hiding this comment.
In main, how would you depend on latest ao changes? I'm worried that if you bump the hash in third-party/ao (that may not have the a dedicated release) and it becomes inconsistent and confusing.
Here's what I suggest
In main:
- Only update third-party/ao to a hash that is consistent with 0.10.0. But not update pyproject.toml
This is not 100% necessary but it's good because (1) we're testing the CI in main (2) making sure main's hash is not older than release branch's
In release branch branch:
- update third-party/ao to a hash that is consistent with 0.10.0.
- update pyproject.toml to be 0.10.0
- update the release checklist to reflect this new process about pinning to torchao.
|
Also in the summary of the PR, please add context and corresponding issue (#9940) |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
This PR is the first step to addressing #9940 and making torchao installable on ET/release/0.6. 1. This PR bumps torchao pin to torchao/release/0.10.0 branch. 2. We will follow-up with a PR in release/0.6 to bump the pin and add torchao==0.10.0 to the pyproject.toml file.
This was referenced Apr 14, 2025
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
This PR is the first step to addressing pytorch#9940 and making torchao installable on ET/release/0.6. 1. This PR bumps torchao pin to torchao/release/0.10.0 branch. 2. We will follow-up with a PR in release/0.6 to bump the pin and add torchao==0.10.0 to the pyproject.toml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step to addressing #9940 and making torchao installable on ET/release/0.6.
This PR bumps torchao pin to torchao/release/0.10.0 branch.
We will follow-up with a PR in release/0.6 to bump the pin and add torchao==0.10.0 to the pyproject.toml file.