Arm backend: Skip instead of returning in Llama test #9906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user does not provide input files with the --llama_inputs argument, the test is not run. Change the return statement into a pytest.skip so that the test output show a skip rather than a pass. Change-Id: I5a1836cb9a16dc5b3fd43e25f1586d901cc8e8f9
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9906
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3b0c04d with merge base cfca108 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot label "partner: arm" |
pytorch-bot
bot
added
the
partner: arm
|
@pytorchbot label ciflow/trunk |
digantdesai
approved these changes
Apr 4, 2025
|
qnn fails is unrelated |
zingo
approved these changes
Apr 4, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
If the user does not provide input files with the --llama_inputs argument, the test is not run. Change the return statement into a pytest.skip so that the test output show a skip rather than a pass. Co-authored-by: Martin Lindström <Martin.Lindstroem@arm.com>
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user does not provide input files with the --llama_inputs argument, the test is not run. Change the return statement into a pytest.skip so that the test output show a skip rather than a pass.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218