Skip to content

Arm backend: Add info message to assertions in fold_qdq_with_annotated_qparams_pass #9895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

Sebastian-Larsson
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented Apr 4, 2025

Add explanation for why the asserts would trigger.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Add explanation for why the asserts would trigger.

Change-Id: I35cb323c848c706c236cdefcd40d40fe68dd5f21
Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Copy link

pytorch-bot bot commented Apr 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9895

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a9a3ad5 with merge base 4717459 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2025
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 4, 2025
@Sebastian-Larsson Sebastian-Larsson changed the title Add info message to assertions in fold_qdq_with_annotated_qparams_pass Arm backend: Add info message to assertions in fold_qdq_with_annotated_qparams_pass Apr 4, 2025
@zingo
Copy link
Collaborator

zingo commented Apr 4, 2025

qnn fails are unrelated

@zingo zingo merged commit b7f35c9 into pytorch:main Apr 4, 2025
166 of 169 checks passed
@Sebastian-Larsson Sebastian-Larsson deleted the info_msg_qdq branch April 4, 2025 14:05
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
…d_qparams_pass (#9895)

Add explanation for why the asserts would trigger.

Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants