Reapply "Depend on extension/threadpool, not thread_parallel_interface, in buck (#9511)" #9890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, in buck (#9511)" Trying again with internal fixes. Original summary: I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Differential Revision: [D72090889](https://our.internmc.facebook.com/intern/diff/D72090889/) [ghstack-poisoned]
swolchok
requested review from
JacobSzwejbka,
lucylq,
manuelcandales and
kimishpatel
as code owners
swolchok
pushed a commit
that referenced
this pull request
Apr 3, 2025
…e, in buck (#9511)" Trying again with internal fixes. Original summary: I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Differential Revision: [D72090889](https://our.internmc.facebook.com/intern/diff/D72090889/) ghstack-source-id: 276012372 Pull Request resolved: #9890
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9890
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e8cf7e3 with merge base 8606725 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72090889 |
…adpool, not thread_parallel_interface, in buck (#9511)"" Trying again with internal fixes. Original summary: I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Differential Revision: [D72090889](https://our.internmc.facebook.com/intern/diff/D72090889/) [ghstack-poisoned]
swolchok
pushed a commit
that referenced
this pull request
Apr 3, 2025
…e, in buck (#9511)" Pull Request resolved: #9890 Trying again with internal fixes. Original summary: I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Differential Revision: [D72090889](https://our.internmc.facebook.com/intern/diff/D72090889/) ghstack-source-id: 276017129
|
This pull request was exported from Phabricator. Differential Revision: D72090889 |
larryliu0820
approved these changes
Apr 4, 2025
facebook-github-bot
merged commit a76f10c
into
gh/swolchok/421/base
83 of 85 checks passed
facebook-github-bot
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
facebook-github-bot
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
|
I'm not sure why the bot failed to CP to main. https://github.com/pytorch/executorch/actions/runs/14274145415/job/40013784902 I will look into this |
facebook-github-bot
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Trying again with internal fixes. Original summary:
I planned to do this everywhere and forgot. Clean it all up, leave a
note, enforce the note with visibility. This makes sure everything in
buck-land gets ET_USE_THREADPOOL.
Differential Revision: D72090889