Release/0.6 #9862
Closed
Release/0.6 #9862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Making it internal till fully converted & leveraging the OSS API. Differential Revision: D71952366 Co-authored-by: Anthony Shoumikhin <anthony@shoumikh.in>
### Summary So that we can still build third-party projects. ### Test plan CI Co-authored-by: Mengwei Liu <larryliu0820@users.noreply.github.com>
### Summary
There is a bug when there is a constant_pad between two convolutions. In
order to minimize permutes associated with memory format changes, we
sometimes compute ops in NHWC. This is the case for ConstantPad when it
is between two convs:
```
a = conv(a)
a = constant_pad(a, paddings=[1, 2, 3, 4])
a = conv(a)
```
in this case we need to make sure the paddings given to constant_pad are
also permuted to nhwc.
### Test plan
python install_executorch.py --editable
python -m unittest
backends.xnnpack.test.ops.test_static_constant_pad.TestStaticConstantPad.test_fp32_static_constant_pad_nhwc
Co-authored-by: Max Ren <40742183+mcr229@users.noreply.github.com>
Co-authored-by: Hansong <107070759+kirklandsign@users.noreply.github.com>
going from .rst to md for the main docs page and cleaned up the content for easier use Co-authored-by: Jesse White <5281939+byjlw@users.noreply.github.com>
For android demo, use links in pytorch-labs/executorch-examples Remove references to old demo app Add video Co-authored-by: Hansong <107070759+kirklandsign@users.noreply.github.com>
Co-authored-by: Hansong <107070759+kirklandsign@users.noreply.github.com>
metascroy
requested review from
GregoryComer,
swolchok,
tarun292,
shoumikhin,
JacobSzwejbka,
kirklandsign,
digantdesai,
mergennachin and
mcr229
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9862
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.
[PLEASE REMOVE] If this PR closes an issue, please add a
Fixes #<issue-id>line.[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.
Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.