Fix scalar type logging from #9751 #9845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9845
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 312df01 with merge base 40443a9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Apr 2, 2025
I forgot that we have a nice system for logging ScalarTypes as strings already. Let's use it. ghstack-source-id: ed9f7fdd9ec36666837adf413718e35d9334b0fd ghstack-comment-id: 2773731655 Pull Request resolved: #9845
manuelcandales
approved these changes
Apr 3, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that we have a nice system for logging ScalarTypes as strings already. Let's use it.