Change training pybind extension_module linkage to static #9809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes #9576. Use `extension_module_static` in building `_training_lib`. Test Plan: Rely on unit test, also did a manual install in editable mode: ```bash ./install_executorch.sh --pybind training python -c "from executorch.extension.training.pybindings._training_lib import get_sgd_optimizer" ``` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9809
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 817b14e with merge base b66c319 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
JacobSzwejbka
approved these changes
Apr 1, 2025
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot cherry-pick —onto release/0.6 -c bugfix |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot cherry-pick --onto release/0.6 --fixes #9576 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 8, 2025
Summary: Fixes #9576. Use `extension_module_static` in building `_training_lib`. Test Plan: Rely on unit test, also did a manual install in editable mode: ```bash ./install_executorch.sh --pybind training -e python -c "from executorch.extension.training.pybindings._training_lib import get_sgd_optimizer" ``` Reviewers: Subscribers: Tasks: Tags: (cherry picked from commit d0bf832)
Cherry picking #9809The cherry pick PR is at #9961 and it is linked with issue #9576. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Summary: Fixes #9576. Use `extension_module_static` in building `_training_lib`. Test Plan: Rely on unit test, also did a manual install in editable mode: ```bash ./install_executorch.sh --pybind training -e python -c "from executorch.extension.training.pybindings._training_lib import get_sgd_optimizer" ``` Reviewers: Subscribers: Tasks: Tags:
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixes #9576. Use
extension_module_staticin building_training_lib.Test Plan: Rely on unit test, also did a manual install in editable mode:
./install_executorch.sh --pybind training -e python -c "from executorch.extension.training.pybindings._training_lib import get_sgd_optimizer"Reviewers:
Subscribers:
Tasks:
Tags: