Skip to content

Turn on XNNPACK by default for wheels #9773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Turn on XNNPACK by default for wheels #9773

merged 1 commit into from
Mar 31, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Mar 31, 2025

Summary

We pretty much always include xnnpack when building wheels, so why not just turn it on by default? If users want it off, they can opt-out.

image

Test plan

CI

Copy link

pytorch-bot bot commented Mar 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9773

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit a8032e3 with merge base 97bca05 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2025
@jathu jathu added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Mar 31, 2025
@jathu jathu force-pushed the jathu/xnnpack-default branch 2 times, most recently from 9b3a2fc to 764c941 Compare March 31, 2025 18:55
@jathu jathu requested review from mergennachin, swolchok and larryliu0820 and removed request for mergennachin March 31, 2025 19:22
@jathu jathu marked this pull request as ready for review March 31, 2025 19:22
@jathu jathu mentioned this pull request Mar 31, 2025
@jathu jathu force-pushed the jathu/xnnpack-default branch from 764c941 to 51a5225 Compare March 31, 2025 21:07
@jathu jathu force-pushed the jathu/xnnpack-default branch from 51a5225 to a8032e3 Compare March 31, 2025 21:07
@jathu jathu merged commit 16e5901 into main Mar 31, 2025
268 of 270 checks passed
@jathu jathu deleted the jathu/xnnpack-default branch March 31, 2025 22:49
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
### Summary

We pretty much always include xnnpack when building wheels, so why not
just turn it on by default? If users want it off, they can opt-out.


![image](https://github.com/user-attachments/assets/f7c7003d-1768-4858-a777-b47064f65e77)


### Test plan

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants