-
Notifications
You must be signed in to change notification settings - Fork 593
elementwise_util: s/common/compute/ almost everywhere and deprecate SAME_AS_COMPUTE #9613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9613
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit aab3e03 with merge base 811352d ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
I'm not sure of the best way to handle SAME_AS_COMMON/SAME_AS_COMPUTE. The problems are as follows:
|
As the code comment says, these APIs are undergoing development (see e.g. #9613) and it's pretty inconvenient that they're incidentally committed-to externally. Mark them deprecated so we have the option to drop that commitment in (IIUC) 0.7. ghstack-source-id: f9ea4ab ghstack-comment-id: 2752758912 Pull-Request-resolved: #9621
we should land this if and only if @manuelcandales agrees it is improving the code, since the diffs I was trying to support with it have been abandoned. |
As the code comment says, these APIs are undergoing development (see e.g. #9613) and it's pretty inconvenient that they're incidentally committed-to externally. Mark them deprecated so we have the option to drop that commitment in (IIUC) 0.7.
…AME_AS_COMPUTE (#9613) As the title says, this is mostly a few related find-replaces, plus marking SupportedTensorDtypes::SAME_AS_COMPUTE deprecated.
As the code comment says, these APIs are undergoing development (see e.g. #9613) and it's pretty inconvenient that they're incidentally committed-to externally. Mark them deprecated so we have the option to drop that commitment in (IIUC) 0.7.
As the title says, this is mostly a few related find-replaces, plus marking SupportedTensorDtypes::SAME_AS_COMPUTE deprecated.