Skip to content

Add optimized ELU implementation #9521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 4, 2025
Merged

Add optimized ELU implementation #9521

merged 26 commits into from
Apr 4, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 22, 2025

Straightforward application of PyTorch code sharing.

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 22, 2025

Copy link

pytorch-bot bot commented Mar 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9521

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3771a15 with merge base c70c208 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Mar 22, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: e75efc9
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2025
@swolchok swolchok marked this pull request as draft March 22, 2025 00:30
@swolchok
Copy link
Contributor Author

swolchok commented Mar 22, 2025

converting to draft because this won't work until we bump the PyTorch pin (I think)

@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Mar 22, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok changed the base branch from gh/swolchok/390/head to gh/swolchok/394/head March 25, 2025 15:57
swolchok added a commit that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 22c9734
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 22c9734
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
@swolchok swolchok marked this pull request as ready for review March 25, 2025 16:16
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: bc31e5d
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 26, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: fe46a4f
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 27, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 50f2d19
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 27, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 0a1d499
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 28, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 5bd376e
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added 2 commits April 2, 2025 09:40
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Apr 2, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: fa4b18e
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added 2 commits April 3, 2025 11:05
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Apr 3, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: f198f69
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added 2 commits April 4, 2025 09:44
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Apr 4, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 38caa4d
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
Base automatically changed from gh/swolchok/394/head to main April 4, 2025 19:26
@swolchok swolchok requested a review from digantdesai as a code owner April 4, 2025 19:26
@swolchok swolchok merged commit 730a4d8 into main Apr 4, 2025
83 of 156 checks passed
@swolchok swolchok deleted the gh/swolchok/391/head branch April 4, 2025 19:26
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
Straightforward application of PyTorch code sharing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants