Enable optimized op_le broadcast against 1 element tensor #9507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9507
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit cea5201 with merge base d980ce0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71652593 |
manuelcandales
added
the
release notes: ops & kernels
larryliu0820
approved these changes
Mar 21, 2025
|
Cool! I have verified the fix. Thanks @manuelcandales ! Can you please fix the linter so we can merge it and then cherry-pick to the release branch. It's affecting several HF models, so would want this fix to be included in the 0.6 release. huggingface/optimum-executorch#14 |
guangy10
approved these changes
Mar 22, 2025
Summary: Will enable full broadcasting support in a future PR. But right now, enabling the 1-element case, to resolve pytorch#9433 Reviewed By: larryliu0820, guangy10 Differential Revision: D71652593
manuelcandales
force-pushed
the
export-D71652593
branch
from
fe19d49 to
cea5201
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71652593 |
guangy10
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Will enable full broadcasting support in a future PR. But right now, enabling the 1-element case, to resolve #9433
Differential Revision: D71652593