[ET-VK] Adding all tensor packing support to split op. #9439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index calculation function in copy op's shader. Pull Request resolved: #9343 This diff adds two new boolean flags, `calc_out_pos_using_src_chnl` and `calc_in_pos_using_dst_chnl` to add_copy_offset_node, which can be used to specify an indexing function in the shader. ghstack-source-id: 272554190 @exported-using-ghexport Differential Revision: [D71343588](https://our.internmc.facebook.com/intern/diff/D71343588/)
…ction. Pull Request resolved: #9344 This diff change `copy_packed_dim_offset` function and associated shader to handle the source_offset parameter. This change will help enable all tensor packing for slice op. ghstack-source-id: 272554186 @exported-using-ghexport Differential Revision: [D71349217](https://our.internmc.facebook.com/intern/diff/D71349217/)
Pull Request resolved: #9345 This diff updates Executorch Vulkan backend's `split` operation to support width, height and channel packed tensors. It also updates the op_registry.py file to indicate `split` operation supports all packing and adds new test cases to the cases.py file to test the operation. ghstack-source-id: 272554188 @exported-using-ghexport Differential Revision: [D71345589](https://our.internmc.facebook.com/intern/diff/D71345589/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9439
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 24e02e4 with merge base 6fb42ef ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Base automatically changed from
gh/trivedivivek/65/orig
to
gh/trivedivivek/64/orig
March 20, 2025 02:58
trivedivivek
approved these changes
Mar 20, 2025
kirklandsign
force-pushed
the
gh/trivedivivek/64/orig
branch
from
624a38c to
b684279
Compare
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#9345 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#9345 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #9345 by @trivedivivek
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/orig
@diff-train-skip-merge