Skip to content

fix building with CMake + Ninja after #9077 #9246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

swolchok
Copy link
Contributor

Needed to tell CMake to tell Ninja where flatc comes from.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 13, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Mar 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9246

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 15 Pending

As of commit 740d4b2 with merge base 630d0cc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Mar 13, 2025
Needed to tell CMake to tell Ninja where flatc comes from.

ghstack-source-id: d700821
ghstack-comment-id: 2722835544
Pull Request resolved: #9246
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2025
@swolchok swolchok requested review from jathu and mergennachin March 13, 2025 22:39
@swolchok swolchok merged commit e9cf64a into main Mar 13, 2025
75 of 77 checks passed
@swolchok swolchok deleted the gh/swolchok/360/head branch March 13, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants