parallelize optimized op_where using parallel_for #9059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2025
| @@ -44,6 +44,9 @@ inline bool parallel_for_no_threadpool( | |||
| return true; | |||
| } | |||
|
|
|||
| // Match GRAIN_SIZE from PyTorch core. | |||
| // https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/TensorIterator.h#L78 | |||
| constexpr int64_t GRAIN_SIZE = 32768; | |||
There was a problem hiding this comment.
Is grain_size how often to open a new thread?
There was a problem hiding this comment.
see lines 58-59 below
JacobSzwejbka
approved these changes
Mar 11, 2025
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal model got a 5.7% latency improvement (313.8 ms before, 296.0 ms after).