Skip to content

[ET-VK][ez] Log GLSL file path on compile error #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

[ET-VK][ez] Log GLSL file path on compile error #9050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion backends/vulkan/runtime/gen_vulkan_spv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,12 @@ def process_shader(shader_paths_pair):
+ self.glslc_flags.split()
)

subprocess.check_call(cmd)
try:
subprocess.check_call(cmd)
except subprocess.CalledProcessError as e:
raise RuntimeError(
f"Failed to compile {os.getcwd()}/{glsl_out_path}"
) from e

return (spv_out_path, glsl_out_path)

Expand Down
Loading