Skip to content

Enable xnnpack in aten mode #9049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Enable xnnpack in aten mode #9049

merged 1 commit into from
May 6, 2025

Conversation

tarun292
Copy link
Contributor

@tarun292 tarun292 commented Mar 7, 2025

Summary: This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Differential Revision: D70704202

Copy link

pytorch-bot bot commented Mar 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9049

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit eef7ef6 with merge base 4dfddf5 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

facebook-github-bot pushed a commit that referenced this pull request Mar 7, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Differential Revision: D70704202
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

tarun292 added a commit that referenced this pull request Mar 20, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
tarun292 added a commit that referenced this pull request Mar 20, 2025
Summary:
Pull Request resolved: #9049

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

# @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole)
link_whole = True,
)
for aten_mode in get_aten_mode_options():
Copy link
Contributor

@digantdesai digantdesai Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dejvu can't remember why we disabled aten-mode anymore, good luck :)

tarun292 added a commit that referenced this pull request Mar 24, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
facebook-github-bot pushed a commit that referenced this pull request Mar 24, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

tarun292 added a commit that referenced this pull request Mar 24, 2025
Summary:
Pull Request resolved: #9049

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
tarun292 added a commit that referenced this pull request Apr 2, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

tarun292 added a commit that referenced this pull request Apr 2, 2025
Summary:
Pull Request resolved: #9049

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
tarun292 added a commit that referenced this pull request May 5, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@tarun292 tarun292 force-pushed the export-D70704202 branch from 6deb886 to 3ead187 Compare May 5, 2025 19:04
facebook-github-bot pushed a commit that referenced this pull request May 5, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

tarun292 added a commit that referenced this pull request May 5, 2025
Summary:
Pull Request resolved: #9049

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@tarun292 tarun292 force-pushed the export-D70704202 branch from c7c3360 to 2647c43 Compare May 5, 2025 19:07
facebook-github-bot pushed a commit that referenced this pull request May 6, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

facebook-github-bot pushed a commit that referenced this pull request May 6, 2025
Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

Summary:

This diff enables XNNPack delegate in ATen mode resolving some compilation issues and also making sure that the deps that XNNPack depends on are portable + aten friendly.

Reviewed By: mcr229

Differential Revision: D70704202
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70704202

@facebook-github-bot facebook-github-bot merged commit 118ce2a into main May 6, 2025
93 of 97 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D70704202 branch May 6, 2025 16:13
phaiting pushed a commit that referenced this pull request May 6, 2025
Differential Revision: D70704202

Pull Request resolved: #9049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants