Skip to content

Arm backend: Add logical And, Or, and Xor operators in Arm backend #9036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

Arm backend: Add logical And, Or, and Xor operators in Arm backend #9036

merged 3 commits into from
Mar 10, 2025

Conversation

YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Mar 7, 2025 •
edited by pytorch-bot bot
Loading

Add logical And, Or, and Xor operators in Arm backend

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@YufengShi-dudu
Arm backend: Add logical And, Or, and Xor operators in Arm backend
ad22b4d 
    1. Implement the logical operatos using binary operator factory.
    2. Disable the logical operators for EthosU55.

Change-Id: I4ea9d697b73ff85fb61ca478316e78296426ef90
Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9036

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 9089532 with merge base 51901f3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 7, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
mansnils
mansnils approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@mansnils mansnils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zingo
Copy link
Collaborator

zingo commented Mar 10, 2025

lintrunner and MacOS test fails are unrealted

@zingo zingo merged commit 94a8bc7 into pytorch:main Mar 10, 2025
120 of 124 checks passed
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansnils mansnils mansnils approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@oscarandersson8218 oscarandersson8218 Awaiting requested review from oscarandersson8218

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YufengShi-dudu @zingo @mansnils @facebook-github-bot