-
Notifications
You must be signed in to change notification settings - Fork 536
Arm backend: Move ReplaceScalarTensorWithFullPass to transforms #8998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The pass is general and can be used by multiple backends. The aten.scalar_tensor is replaced by a aten.full which is already supported by Arm backend. Adds new method to Arm tester for getting output as the nn.module in the unit test does not take any input. The output is then manually compared within the unit test. Change-Id: I2bf211a2ce561d53e8a6cf683fdbda58e675938e
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8998
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 69879d5 with merge base 043c7a0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label ciflow/trunk |
@digantdesai, @kimishpatel can you take a look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like just moving a pass around. Didnt fully follow but accepting it. cc @mcremon-meta for cadence related code movement. Bunch of tests are failing though. @tarun292 does it need to be imported internally to validate? Please wait for @tarun292 's answer before landing
looks fine to share the code from our end! We would just ask that (like in this PR) the passes are not modified at least in the PR that moves them so that we can keep track of changes :) |
Looks like you are ok with landing these then. |
yes no blocker from our side if CI etc is alright! |
@@ -0,0 +1,42 @@ | |||
# Copyright (c) Meta Platforms, Inc. and affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you this is the right thing to do.
@mansnils this branch needs to be rebased so and conflicts need to be resolved so we can merge |
This has been replaced with another PR, so closing this |
The pass is general and can be used by multiple backends. The aten.scalar_tensor is replaced by a aten.full which is already supported by Arm backend.
Adds new method to Arm tester for getting output as the nn.module in the unit test does not take any input. The output is then manually compared within the unit test.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218