-
Notifications
You must be signed in to change notification settings - Fork 536
Fix flatcc path for Windows #8970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8970
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit fce39dc with merge base 6eee931 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
devtools/CMakeLists.txt
Outdated
@@ -159,6 +163,15 @@ file(MAKE_DIRECTORY | |||
${_program_schema__include_dir}/executorch/devtools/bundled_program | |||
) | |||
|
|||
message("Hello") | |||
message("${CMAKE_GENERATOR}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, good catch :p
if(WIN32) | ||
set(RM_COMMAND rmdir /s /q) | ||
else() | ||
set(RM_COMMAND rm -rf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm -rf in a cmakefile makes me a little uneasy, why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know; rm -rf
was being used before my changes. Here I'm simply switching it to use a cmd.exe
equivalent for Windows. I can change it to rm -r
if that's more reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok looks like it was there before, so hopefully should be fine i guess
cc: @tarun292 |
test failure is most probably unrelated. |
Summary
This PR is based on #4993 but includes an additional fix to use the correct equivalent of the
rm -rf
command for Windows.Test plan
Built ExecuTorch for Windows using the following command: