Properly export ET_USE_THREADPOOL from the threadpool extension #8947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
requested review from
kimishpatel,
jackzhxng,
iseeyuan,
larryliu0820,
kirklandsign,
lucylq,
GregoryComer and
dbort
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8947
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5a283c8 with merge base 484231c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
approved these changes
Mar 4, 2025
|
noting that CI is 100% green in case I rebase |
swolchok
added a commit
that referenced
this pull request
Mar 5, 2025
We had a bunch of targets that would define this macro ad-hoc. It's supposed to indicate that the threadpool extension is available, so just make sure that we have it as a PUBLIC `target_compile_definition` in CMake and an `exported_preprocessor_flags` entry in Buck for extension_threadpool. Test Plan: CI on following NOCOMMIT PR, which fails builds if ET_USE_THREADPOOL is not defined in affected places. ghstack-source-id: 9b3a0ca ghstack-comment-id: 2699165786 Pull Request resolved: #8947
This was referenced Mar 5, 2025
swolchok
changed the base branch from
gh/swolchok/307/head
to
gh/swolchok/318/head
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bunch of targets that would define this macro ad-hoc. It's supposed to indicate that the threadpool extension is available, so just make sure that we have it as a PUBLIC
target_compile_definitionin CMake and anexported_preprocessor_flagsentry in Buck for extension_threadpool.Test Plan: CI on following NOCOMMIT PR, which fails builds if ET_USE_THREADPOOL is not defined in affected places.
Needed for #8932.