[Android demo] Decouple pte file from assets and remove unused#8906
Merged
Conversation
Instead, load pte file from /data/local/tmp/, which makes packaging the APK much faster. Meanwhile, remove unused activities and asset files.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8906
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ff70cf0 with merge base 24671a9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
Contributor
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shoumikhin
approved these changes
Mar 4, 2025
Contributor
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
zonglinpeng
pushed a commit
that referenced
this pull request
Mar 6, 2025
Differential Revision: D70528015 Pull Request resolved: #8906
This was referenced Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead, load pte file from /data/local/tmp/, which makes packaging the APK much faster.
Meanwhile, remove unused activities and asset files.
Test plan
CI