add pass to remove cat from slice pass #8857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8857
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 0a04324 with merge base 6099020 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70425971 |
|
This pull request was exported from Phabricator. Differential Revision: D70425971 |
zonglinpeng
force-pushed
the
export-D70425971
branch
2 times, most recently
from
1420d2e to
2a06f66
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Mar 1, 2025
Summary: only keep the cat before slice iff the slice range overlaps with *both* tensors in cat. TODO: trace to 1+ level for more cat in a china TODO: support >2 tensors in a cat Differential Revision: D70425971
|
This pull request was exported from Phabricator. Differential Revision: D70425971 |
zonglinpeng
force-pushed
the
export-D70425971
branch
from
2a06f66 to
df4f8a0
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Mar 7, 2025
Summary: only keep the cat before slice iff the slice range overlaps with *both* tensors in cat. TODO: trace to 1+ level for more cat in a china TODO: support >2 tensors in a cat Differential Revision: D70425971
|
This pull request was exported from Phabricator. Differential Revision: D70425971 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Mar 7, 2025
Summary: Pull Request resolved: pytorch#8857 only keep the cat before slice iff the slice range overlaps with *both* tensors in cat. TODO: trace to 1+ level for more cat in a china TODO: support >2 tensors in a cat Differential Revision: D70425971
zonglinpeng
force-pushed
the
export-D70425971
branch
from
df4f8a0 to
e5940fe
Compare
Summary: only keep the cat before slice iff the slice range overlaps with *both* tensors in cat. TODO: trace to 1+ level for more cat in a china TODO: support >2 tensors in a cat Reviewed By: bingcy Differential Revision: D70425971
zonglinpeng
force-pushed
the
export-D70425971
branch
from
e5940fe to
0a04324
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70425971 |
skrtskrtfb
approved these changes
Mar 7, 2025
Merged
|
this added a lintrunner failure https://github.com/pytorch/executorch/actions/runs/13730950536/job/38407785027 |
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
only keep the cat before slice iff the slice range overlaps with both tensors in cat.
TODO: trace to 1+ level for more cat in a china
TODO: support >2 tensors in a cat
Differential Revision: D70425971