Fix static_llama to read some previously hardcoded options from ModelArgs #8846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8846
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 53f000f with merge base 781b082 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
…Args Differential Revision: D70414663
|
This pull request was exported from Phabricator. Differential Revision: D70414663 |
|
This pull request was exported from Phabricator. Differential Revision: D70414663 |
sxu
force-pushed
the
export-D70414663
branch
from
c13bb41 to
53f000f
Compare
cccclai
reviewed
Feb 28, 2025
| @@ -37,7 +37,7 @@ def __init__(self, config: ModelArgs, output_new_cache_only=False): | |||
| super().__init__() | |||
| self.dim = config.dim | |||
| self.n_heads = config.n_heads | |||
| self.head_dim = config.dim // config.n_heads | |||
| self.head_dim = config.head_dim | |||
There was a problem hiding this comment.
Maybe I miss something, isn't head_dim the same as dim / n_heads?
There was a problem hiding this comment.
Not necessarily, it can be anything, it's internal to the attention, the wo layer make sure the output of the attention has size dim.
navsud
approved these changes
Mar 1, 2025
navsud
pushed a commit
to navsud/executorch
that referenced
this pull request
Mar 4, 2025
Summary: After pytorch#8846, the models exported correctly, but failed to run on-device with segmentation error. This diff fixes that error. Reviewed By: sxu, billmguo Differential Revision: D70538475
navsud
pushed a commit
to navsud/executorch
that referenced
this pull request
Mar 4, 2025
Summary: After pytorch#8846, the models exported correctly, but failed to run on-device with segmentation error. This diff fixes that error. Reviewed By: sxu, billmguo Differential Revision: D70538475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D70414663