Migrate pybind11 external deps to regular third-party deps #8837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamaro
requested review from
JacobSzwejbka,
tarun292,
larryliu0820,
cccclai and
shoumikhin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8837
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 6fda940 with merge base 19a3002 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
|
This pull request was exported from Phabricator. Differential Revision: D70261352 |
|
This pull request was exported from Phabricator. Differential Revision: D70261352 |
itamaro
force-pushed
the
export-D70261352
branch
from
2fab178 to
a46fb6a
Compare
itamaro
force-pushed
the
export-D70261352
branch
from
a46fb6a to
21b8467
Compare
itamaro
added a commit
to itamaro/executorch
that referenced
this pull request
Mar 1, 2025
) Summary: ``` >pylot run fbcode//scripts/yilei/codemods:replace_tp2_deps --tp2_project=pybind11 --replacement=fbsource//third-party/pybind11:pybind11 E0226 10:26:07.491569 2744864 Config.cpp:1179] For smc tier ''. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. E0226 10:26:07.493572 2744864 Config.cpp:1179] For smc tier ''. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. E0226 10:26:07.493769 2744864 Config.cpp:1179] For smc tier ''. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. E0226 10:26:07.550289 2745009 Config.cpp:1179] For smc tier 'biggrep.master.trusted'. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. E0226 10:26:07.556802 2745009 Config.cpp:1179] For smc tier 'biggrep.aggregator.interactive.v1'. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. Found 163 TARGETS files using tp2 pybind11 [######------------------------------] 19% 00:01:39WARNING: Y2_MAGIC_STRING_FOR_BUILDOZER found in fbcode/bolt/nn/executorch/backends/targets.bzl [###########-------------------------] 32% 00:01:28WARNING: Y2_MAGIC_STRING_FOR_BUILDOZER found in fbcode/executorch/backends/qualcomm/aot/python/targets.bzl [###########-------------------------] 33% 00:01:27WARNING: Y2_MAGIC_STRING_FOR_BUILDOZER found in fbcode/executorch/codegen/tools/fb/targets.bzl [####################################] 100% ``` this codemod changes pybind11 deps from external deps to regular third-party deps. additional changes include trivial auto-formatting. buck / autodeps warnings / errors, if any, are pre-existing. Reviewed By: cccclai, dtolnay Differential Revision: D70261352
) Summary: Pull Request resolved: pytorch#8837 ``` >pylot run fbcode//scripts/yilei/codemods:replace_tp2_deps --tp2_project=pybind11 --replacement=fbsource//third-party/pybind11:pybind11 E0226 10:26:07.491569 2744864 Config.cpp:1179] For smc tier ''. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. E0226 10:26:07.493572 2744864 Config.cpp:1179] For smc tier ''. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. E0226 10:26:07.493769 2744864 Config.cpp:1179] For smc tier ''. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. E0226 10:26:07.550289 2745009 Config.cpp:1179] For smc tier 'biggrep.master.trusted'. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. E0226 10:26:07.556802 2745009 Config.cpp:1179] For smc tier 'biggrep.aggregator.interactive.v1'. Encountered an exception while parsing 'weight_mode'. Failed to parse WeightMode: Unknown WeightMode value 'default_sr'. Using 'LEGACY_DEFAULT'. Found 163 TARGETS files using tp2 pybind11 [######------------------------------] 19% 00:01:39WARNING: Y2_MAGIC_STRING_FOR_BUILDOZER found in fbcode/bolt/nn/executorch/backends/targets.bzl [###########-------------------------] 32% 00:01:28WARNING: Y2_MAGIC_STRING_FOR_BUILDOZER found in fbcode/executorch/backends/qualcomm/aot/python/targets.bzl [###########-------------------------] 33% 00:01:27WARNING: Y2_MAGIC_STRING_FOR_BUILDOZER found in fbcode/executorch/codegen/tools/fb/targets.bzl [####################################] 100% ``` this codemod changes pybind11 deps from external deps to regular third-party deps. additional changes include trivial auto-formatting. buck / autodeps warnings / errors, if any, are pre-existing. Reviewed By: cccclai, dtolnay Differential Revision: D70261352
|
This pull request was exported from Phabricator. Differential Revision: D70261352 |
itamaro
force-pushed
the
export-D70261352
branch
from
21b8467 to
6fda940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewed By: dtolnay
Differential Revision: D70261352