[build] Add editable mode unittest #8817

larryliu0820 · 2025-02-28T05:01:20Z

Stack from ghstack (oldest at bottom):

As titled. To do this we need to refactor the arguments being passed
into setup-linux.sh setup-macos.sh and unittest-linux.sh
unittest-macos.sh.

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

pytorch-bot · 2025-02-28T05:01:23Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8817

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 7 Pending

As of commit f5df1b3 with merge base 76fb844 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 3b91bfd Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: d8c8aa5 Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 4e3c467 Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 2f5bc65 Pull Request resolved: #8817

mergennachin · 2025-02-28T15:49:43Z

Thanks for adding this test, looks like a good change, let's fix CI tho.

swolchok

if the tests pass, ship it

.ci/scripts/utils.sh

.ci/scripts/setup-linux.sh

.github/workflows/_unittest.yml

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: d3c3d8e Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 94fad23 Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: a297ee1 Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 4e4360b Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: ea90805 Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 015cf34 Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: f59485c Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 19ab827 Pull Request resolved: #8817

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 19ab827 Pull Request resolved: #8817 Co-authored-by: Mengwei Liu <larryliu@fb.com>

Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to #144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: #149539 Approved by: https://github.com/larryliu0820

Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to #144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: #149539 Approved by: https://github.com/larryliu0820 (cherry picked from commit bc86b6c)

Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to #144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: #149539 Approved by: https://github.com/larryliu0820

Update ExecuTorch pin update (#149539) Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to #144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: #149539 Approved by: https://github.com/larryliu0820 (cherry picked from commit bc86b6c)

Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to pytorch#144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: pytorch#149539 Approved by: https://github.com/larryliu0820

[build] Add editable mode unittest

3ec4099

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

larryliu0820 mentioned this pull request Feb 28, 2025

[build] Fix flatc #8816

Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025

larryliu0820 added the topic: not user facing label Feb 28, 2025

larryliu0820 had a problem deploying to upload-benchmark-results February 28, 2025 05:12 — with GitHub Actions Failure

Update on "[build] Add editable mode unittest"

1a229ce

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

Update on "[build] Add editable mode unittest"

30427d9

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

Update on "[build] Add editable mode unittest"

44c4546

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

larryliu0820 had a problem deploying to upload-benchmark-results February 28, 2025 05:36 — with GitHub Actions Failure

larryliu0820 had a problem deploying to upload-benchmark-results February 28, 2025 08:04 — with GitHub Actions Failure

mergennachin requested review from swolchok and mergennachin February 28, 2025 15:46

swolchok approved these changes Feb 28, 2025

View reviewed changes

.ci/scripts/utils.sh Show resolved Hide resolved

.ci/scripts/setup-linux.sh Outdated Show resolved Hide resolved

.github/workflows/_unittest.yml Outdated Show resolved Hide resolved

Update on "[build] Add editable mode unittest"

133c015

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

larryliu0820 had a problem deploying to upload-benchmark-results February 28, 2025 19:11 — with GitHub Actions Failure

larryliu0820 had a problem deploying to upload-benchmark-results February 28, 2025 19:15 — with GitHub Actions Failure

Update on "[build] Add editable mode unittest"

e11e41f

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

larryliu0820 had a problem deploying to upload-benchmark-results February 28, 2025 19:59 — with GitHub Actions Failure

Update on "[build] Add editable mode unittest"

5c9a49c

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

larryliu0820 had a problem deploying to upload-benchmark-results February 28, 2025 20:18 — with GitHub Actions Failure

larryliu0820 had a problem deploying to upload-benchmark-results February 28, 2025 20:50 — with GitHub Actions Failure

Update on "[build] Add editable mode unittest"

b3bca69

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

larryliu0820 temporarily deployed to upload-benchmark-results February 28, 2025 21:48 — with GitHub Actions Inactive

larryliu0820 temporarily deployed to upload-benchmark-results February 28, 2025 22:17 — with GitHub Actions Inactive

Update on "[build] Add editable mode unittest"

b9f3349

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

Update on "[build] Add editable mode unittest"

c9c41e0

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

Update on "[build] Add editable mode unittest"

443928e

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

Update on "[build] Add editable mode unittest"

f5df1b3

As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]

larryliu0820 temporarily deployed to upload-benchmark-results February 28, 2025 23:33 — with GitHub Actions Inactive

larryliu0820 merged commit c4de36a into gh/larryliu0820/62/base Feb 28, 2025
105 of 106 checks passed

larryliu0820 deleted the gh/larryliu0820/62/head branch February 28, 2025 23:51

larryliu0820 temporarily deployed to cherry-pick-bot February 28, 2025 23:51 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Feb 28, 2025

[build] Add editable mode unittest #8855

Merged

larryliu0820 temporarily deployed to upload-benchmark-results March 1, 2025 00:05 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Mar 1, 2025

[build] Fix flatc #8858

Merged

mergennachin mentioned this pull request Mar 19, 2025

Update ExecuTorch pin update pytorch/pytorch#149539

Closed

mergennachin mentioned this pull request Mar 20, 2025

[cherry-pick] Update ExecuTorch pin update (#149539) pytorch/pytorch#149630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build] Add editable mode unittest #8817

[build] Add editable mode unittest #8817

larryliu0820 commented Feb 28, 2025 •

edited

Loading

pytorch-bot bot commented Feb 28, 2025 •

edited

Loading

mergennachin commented Feb 28, 2025 •

edited

Loading

swolchok left a comment

[build] Add editable mode unittest #8817

[build] Add editable mode unittest #8817

Conversation

larryliu0820 commented Feb 28, 2025 • edited Loading

pytorch-bot bot commented Feb 28, 2025 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8817

⏳ No Failures, 7 Pending

mergennachin commented Feb 28, 2025 • edited Loading

swolchok left a comment

Choose a reason for hiding this comment

larryliu0820 commented Feb 28, 2025 •

edited

Loading

pytorch-bot bot commented Feb 28, 2025 •

edited

Loading

mergennachin commented Feb 28, 2025 •

edited

Loading