[ExecuTorch][XNNPACK] Don't partition per_tensor weights with qd8 #8787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8787
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1b91adb with merge base 542480c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
digantdesai
added a commit
that referenced
this pull request
Feb 27, 2025
This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/) ghstack-source-id: 268822901 Pull Request resolved: #8787
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70343584 |
…ith qd8" This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/) [ghstack-poisoned]
digantdesai
added a commit
that referenced
this pull request
Feb 28, 2025
Pull Request resolved: #8787 This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. ghstack-source-id: 268894461 @exported-using-ghexport Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)
mcr229
approved these changes
Feb 28, 2025
No worries. I started to feel gemm_config needs a refactor. It is too complex now. 😃 |
…ith qd8" This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/) [ghstack-poisoned]
…ith qd8" This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/) [ghstack-poisoned]
|
@digantdesai perhaps we can add a util function that goes through all the quant/dequant nodes in the partition, and validates those. And we can call that for every quantized op |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Mar 3, 2025
Summary: This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. ghstack-source-id: 269356867 exported-using-ghexport Reviewed By: mcr229 Differential Revision: D70343584
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Mar 3, 2025
Summary: Pull Request resolved: pytorch#8787 This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. ghstack-source-id: 269356867 exported-using-ghexport Reviewed By: mcr229 Differential Revision: D70343584
digantdesai
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is not supported, so we shouldn't partition it.
Add an expectedFailure test to indicate that this is not supported.
Differential Revision: D70343584