Use runtime.python_library in our BUCK/TARGETS files #8712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

swolchok wants to merge 17 commits into main from gh/swolchok/290/head

Contributor

swolchok commented Feb 26, 2025 •

edited

Loading

IIUC, we should've been doing this all along for compatibility with OSS Buck. Was blocking buck2 build //runtime/... (which is still failing, but differently).

Differential Revision: D70647459

swolchok added 11 commits

February 24, 2025 17:27


          Update

65aeed2

[ghstack-poisoned]


          Update

545a05b

[ghstack-poisoned]


          Update

d85e255

[ghstack-poisoned]


          Update

5124a63

[ghstack-poisoned]


          Update

146cfa6

[ghstack-poisoned]


          Update

dce054b

[ghstack-poisoned]


          Update

40bcf6f

[ghstack-poisoned]


          Update

cece5bc

[ghstack-poisoned]


          Update

3c40a8b

[ghstack-poisoned]


          Update

96b69c8

[ghstack-poisoned]


          Update

699a8f4

[ghstack-poisoned]

Contributor Author

swolchok commented Feb 26, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

swolchok requested review from larryliu0820, kirklandsign, JacobSzwejbka, jackzhxng, iseeyuan, tarun292, cccclai, lucylq, Gasoonjia, digantdesai, mcr229 and SS-JIA as code owners

February 26, 2025 00:23

pytorch-bot bot commented Feb 26, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8712

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 6 Pending

As of commit eabf3ff with merge base 484231c ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok mentioned this pull request

test buck2 query for much more of the repo #8660

Merged

facebook-github-bot added the CLA Signed label

swolchok mentioned this pull request

remove exir:_warnings dep from executorch_pybindings buck rule #8710

Merged

swolchok added a commit that referenced this pull request


          Use runtime.python_library in our BUCK/TARGETS files

7fb1dcc

IIUC, we should've been doing this all along for compatibility with OSS Buck. Was blocking `buck2 build //runtime/...` (which is still failing, but differently).

ghstack-source-id: db05394
ghstack-comment-id: 2683586060
Pull Request resolved: #8712

swolchok mentioned this pull request

Test most of //runtime in unittest-buck #8713

Merged

mergennachin self-requested a review

February 26, 2025 14:53

mergennachin approved these changes

View reviewed changes

kirklandsign approved these changes

View reviewed changes

Base automatically changed from gh/swolchok/289/head to main

February 28, 2025 18:02


          Update

8d3a9ba

[ghstack-poisoned]

swolchok added the topic: not user facing label

Contributor

facebook-github-bot commented Feb 28, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

larryliu0820 approved these changes

View reviewed changes

Contributor Author

swolchok commented Feb 28, 2025

internal build failures; holding off merge until they are fixed


          Update

[ghstack-poisoned]

Contributor

facebook-github-bot commented Mar 4, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Update

ea92179

[ghstack-poisoned]

swolchok mentioned this pull request

Default ExecuTorch targets to ExecuTorch-wide Buck visibility #8969

Merged


          Update

891fb8e

[ghstack-poisoned]

swolchok changed the base branch from main to gh/swolchok/313/head

March 5, 2025 19:26

Contributor Author

swolchok commented Mar 5, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

swolchok added a commit that referenced this pull request


          Default ExecuTorch targets to ExecuTorch-wide Buck visibility (#8969)

b3f97aa

IMO, Buck visibility is just inverse deps. We should trust that people have a good reason to add deps rather than attempt to police them and require double entry in both deps and visibility, especially since we seem to be committed to APIs by default in OSS anyway.

Specific motivation is that #8712 would otherwise have to ad-hoc slap ExecuTorch-wide visibility on a lot of targets, but I've held this view for a long time.

Differential Revision: D70647462

Base automatically changed from gh/swolchok/313/head to main

March 5, 2025 21:26

zonglinpeng pushed a commit that referenced this pull request


          Default ExecuTorch targets to ExecuTorch-wide Buck visibility (#8969)

5e244df

IMO, Buck visibility is just inverse deps. We should trust that people have a good reason to add deps rather than attempt to police them and require double entry in both deps and visibility, especially since we seem to be committed to APIs by default in OSS anyway.

Specific motivation is that #8712 would otherwise have to ad-hoc slap ExecuTorch-wide visibility on a lot of targets, but I've held this view for a long time.

Differential Revision: D70647462


          Update

26a2025

[ghstack-poisoned]

swolchok mentioned this pull request

Query most of //kernels in unittest buck #9040

Merged


          Update

eabf3ff

[ghstack-poisoned]

Contributor

facebook-github-bot commented Mar 7, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

This was referenced Mar 7, 2025

Build/test //kernels/portable/cpu/... in unittest-buck #9041

Merged

Build/test //kernels/portable/... in unittest-buck #9042

Merged

Contributor Author

swolchok commented Mar 7, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

swolchok commented Mar 7, 2025

giving up on this for now because I've had to give up on buck2 build //runtime/... anyway and it is continually causing internal problems because the old setting defaulted to visibility = ["PUBLIC"] and the new one is not public.

swolchok closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mergennachin mergennachin approved these changes

larryliu0820 larryliu0820 approved these changes

kirklandsign kirklandsign approved these changes

JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

iseeyuan Awaiting requested review from iseeyuan iseeyuan is a code owner

tarun292 Awaiting requested review from tarun292 tarun292 is a code owner

cccclai Awaiting requested review from cccclai cccclai is a code owner

lucylq Awaiting requested review from lucylq lucylq is a code owner

Gasoonjia Awaiting requested review from Gasoonjia Gasoonjia is a code owner

digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

mcr229 Awaiting requested review from mcr229 mcr229 is a code owner

SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

Labels

CLA Signed topic: not user facing