Skip to content

remove exir:_warnings dep from executorch_pybindings buck rule #8710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 28, 2025
Merged

remove exir:_warnings dep from executorch_pybindings buck rule #8710

merged 10 commits into from
Feb 28, 2025

Conversation

swolchok
Copy link
Contributor

Per @larryliu0820. It was blocking buck2 build //runtime/... (which is still failing, but differently)

@swolchok
Update
65aeed2 
[ghstack-poisoned]
@swolchok
Update
545a05b 
[ghstack-poisoned]
@swolchok
Update
d85e255 
[ghstack-poisoned]
@swolchok
Update
5124a63 
[ghstack-poisoned]
@swolchok
Update
146cfa6 
[ghstack-poisoned]
@swolchok
Update
dce054b 
[ghstack-poisoned]
@swolchok
Update
40bcf6f 
[ghstack-poisoned]
@swolchok
Update
cece5bc 
[ghstack-poisoned]
@swolchok
Update
3c40a8b 
[ghstack-poisoned]
@swolchok
Update
96b69c8 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 26, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@swolchok swolchok mentioned this pull request Feb 26, 2025
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8710

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 96b69c8 with merge base 2be4e94 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Feb 26, 2025
@swolchok
remove exir:_warnings dep from executorch_pybindings buck rule
b1c30c4 
Per larryliu0820. It was blocking buck2 build //runtime/... (which is still failing, but differently)

ghstack-source-id: e11cc8b
ghstack-comment-id: 2683568403
Pull Request resolved: #8710
@swolchok swolchok mentioned this pull request Feb 26, 2025
Closed
@swolchok swolchok mentioned this pull request Feb 26, 2025
Merged
Base automatically changed from gh/swolchok/284/head to main February 28, 2025 16:10
@facebook-github-bot
Copy link
Contributor

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok swolchok merged commit a5750fb into main Feb 28, 2025
83 of 84 checks passed
@swolchok swolchok deleted the gh/swolchok/289/head branch February 28, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@dbort dbort Awaiting requested review from dbort

@lucylq lucylq Awaiting requested review from lucylq

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @facebook-github-bot @JacobSzwejbka