Skip to content

Merge updated documentation into master #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 26, 2025
Merged

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Feb 23, 2025

Summary

This PR brings the updated documentation flow from the executorch-just-works branch into master. This is part of a larger effort (#8048 and #8391) to overhaul the ET documentation, with a focus on improving the content, conciseness, and overall documentation flow. The initial work for this effort has been done on a branch, to avoid breaking the nightly docs while we make larger changes. The overall documentation on the branch is now in a sufficiently mature state that we can move back to working on master as we continue to fill out and refine the documentation.

Test plan

The constituent commits were reviewed on the executorch-just-works branch. I've also locally built the documentation to verify that content and formatting appear correct.

cc @mergennachin @byjlw

Copy link

pytorch-bot bot commented Feb 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8638

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 38 Pending

As of commit 03e724c with merge base 84273f4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2025
@GregoryComer GregoryComer added release notes: misc Miscellaneous module: doc Issues related to documentation, both in docs/ and inlined in code labels Feb 23, 2025
@GregoryComer GregoryComer requested a review from byjlw February 23, 2025 04:46
@mergennachin
Copy link
Contributor

I think when you moved/renamed a page, there are some references in the repo and doc that is now broken:

Here's an example: https://github.com/search?q=repo%3Apytorch%2Fexecutorch%20build-run-mps&type=code

Can you double check all the existing references to the links are not broken by searching "git grep"?

@mergennachin
Copy link
Contributor

Chatted offline, Gregory is doing a few necessary changes in #8672 before merging into main

@GregoryComer
Copy link
Member Author

@mergennachin I've hopefully addressed the remaining items. I've created a follow-up task on the stable docs issue (#8728), since it's slightly tricky. Any additional requests before approving this PR? Thanks!

@mergennachin
Copy link
Contributor

Make sure to resolve conflict with #8690 during rebase

Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looking great

Add placeholder top-level doc pages
Write new top-level export and lowering documentation
* Move cmake and faq docs to new location

* Rename CMake build to Building from Source
* Temporarily remove new backend pages

* Move backend docs to new locations

* Update backend titles and inline contents
Add backend template, update XNNPACK docs
* Temporarily remove using-executorch-ios.md

* Move Apple runtime docs to new location
… C++ APIs, Android, and troubleshooting (#8618)

* Clean up getting-started.md, remove placeholders

* Move Android pre-built AAR info into top-level Android page

* Add placeholder backend overview

* Add placeholder troubleshooting docs

* Populate top-level C++ API doc

* Clean up additional doc placeholders and fix broken links

* Add env setup instructions for source build
Fix quotes in getting started code snippets
Clean up a few more broken links and sections in new doc flow
@GregoryComer GregoryComer merged commit c6761f4 into main Feb 26, 2025
44 of 45 checks passed
@GregoryComer GregoryComer deleted the executorch-just-works branch February 26, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: doc Issues related to documentation, both in docs/ and inlined in code release notes: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants