Address various warnings as errors #8581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8581
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit b3e022a with merge base 9841e54 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
|
A few remaining errors in OSS CI: hhttps://github.com/pytorch/executorch/actions/runs/13422197087/job/37540258041 and also lint error: https://github.com/pytorch/executorch/actions/runs/13422197104/job/37540247065?pr=8581 |
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
force-pushed
the
export-D69139962
branch
from
e1bd3ea to
34c5662
Compare
JakeStevens
requested review from
larryliu0820 and
kirklandsign
as code owners
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 20, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
requested review from
JacobSzwejbka,
lucylq and
manuelcandales
as code owners
|
@pytorchbot label "topic: not user facing |
|
❌ 🤖 pytorchbot command failed: |
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
force-pushed
the
export-D69139962
branch
from
34c5662 to
de3bf42
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 20, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 20, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
de3bf42 to
eb5aab3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 20, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
eb5aab3 to
e1dd14e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
0dc65a2 to
bf4c172
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
bf4c172 to
006df4e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
006df4e to
2eb3f10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
2eb3f10 to
d463d14
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
d463d14 to
f684260
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
f684260 to
54fe659
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
force-pushed
the
export-D69139962
branch
from
54fe659 to
c6e9f7d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
force-pushed
the
export-D69139962
branch
from
c6e9f7d to
022df06
Compare
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
|
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
force-pushed
the
export-D69139962
branch
from
022df06 to
b3e022a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some projects uses more restrictive build options than currently used in ET CI.
This means we encountered a number of errors when enabling for a microcontroller.
Reviewed By: digantdesai, swolchok
Differential Revision: D69139962