patch op name discrepancy in oss #8491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8491
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 23538a1 with merge base 08eb5be ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69568677 |
Summary: 1. Few of the operators are renamed: quantized_relu_out --> quantized_relu_per_tensor_out where_out --> where_self_out mean_dim_out --> mean softmax_out --> __softmax_out clamp_tensor_out --> clamp_Tensor_out corresponding .yml (functions_hifi.yaml) needs to be updated. 2. Name changes of quantize files from quantized_linear_out.cpp, quantized_layer_norm.cpp,quantized_fully_connected_out.cpp, quantize_per_tensor.cpp,quantized_relu_out.cpp,dequantize_per_tensor.cpp to op_quantized_linear_out.cpp, op_quantized_layer_norm.cpp,op_quantized_fully_connected_out.cpp, op_quantize_per_tensor.cpp,op_quantized_relu_out.cpp,op_dequantize_per_tensor.cpp CMakeLists.txt has to be changed to change the file names. 3. yml file has to be changed for quantized kernels to use per_tensor_out versions. Differential Revision: D69568677
zonglinpeng
force-pushed
the
export-D69568677
branch
from
734d8d6 to
23538a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69568677 |
skrtskrtfb
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
quantized_relu_out --> quantized_relu_per_tensor_out
where_out --> where_self_out
mean_dim_out --> mean
softmax_out --> __softmax_out
clamp_tensor_out --> clamp_Tensor_out
corresponding .yml (functions_hifi.yaml) needs to be updated.
quantized_linear_out.cpp, quantized_layer_norm.cpp,quantized_fully_connected_out.cpp,
quantize_per_tensor.cpp,quantized_relu_out.cpp,dequantize_per_tensor.cpp
to
op_quantized_linear_out.cpp, op_quantized_layer_norm.cpp,op_quantized_fully_connected_out.cpp,
op_quantize_per_tensor.cpp,op_quantized_relu_out.cpp,op_dequantize_per_tensor.cpp
CMakeLists.txt has to be changed to change the file names.
Differential Revision: D69568677