Skip to content

Conversation

swolchok
Copy link
Contributor

Removed all explicit setting of CMAKE_PREFIX_PATH to the torch directory in favor of automatically doing it when we find_package(Torch). Hat tip to @huydhn for showing the way to only find torch once.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 13, 2025

Copy link

pytorch-bot bot commented Feb 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8474

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 38720f4 with merge base a01571f (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2025
swolchok added a commit that referenced this pull request Feb 13, 2025
…ave to

Removed all explicit setting of CMAKE_PREFIX_PATH to the torch directory in favor of automatically doing it when we find_package(Torch). Hat tip to huydhn for showing the way to only find torch once.

ghstack-source-id: 202d8ee
ghstack-comment-id: 2657445695
Pull Request resolved: #8474
@swolchok
Copy link
Contributor Author

this one should wait for fully green CI before landing since I'm messing with CI scripts

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 13, 2025
…ave to

Removed all explicit setting of CMAKE_PREFIX_PATH to the torch directory in favor of automatically doing it when we find_package(Torch). Hat tip to huydhn for showing the way to only find torch once.

ghstack-source-id: bc44470
ghstack-comment-id: 2657445695
Pull Request resolved: #8474
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Feb 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 13, 2025
…ave to

Removed all explicit setting of CMAKE_PREFIX_PATH to the torch directory in favor of automatically doing it when we find_package(Torch). Hat tip to huydhn for showing the way to only find torch once.

ghstack-source-id: f66416e
ghstack-comment-id: 2657445695
Pull Request resolved: #8474
@huydhn huydhn added the ciflow/android Trigger Android CI label Feb 14, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 14, 2025
…ave to

Removed all explicit setting of CMAKE_PREFIX_PATH to the torch directory in favor of automatically doing it when we find_package(Torch). Hat tip to huydhn for showing the way to only find torch once.

ghstack-source-id: 1c5ebd2
ghstack-comment-id: 2657445695
Pull Request resolved: #8474
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 18, 2025
…ave to

Removed all explicit setting of CMAKE_PREFIX_PATH to the torch directory in favor of automatically doing it when we find_package(Torch). Hat tip to huydhn for showing the way to only find torch once.

ghstack-source-id: 8042cef
ghstack-comment-id: 2657445695
Pull Request resolved: #8474
@swolchok swolchok merged commit c00c798 into main Feb 18, 2025
145 of 146 checks passed
@swolchok swolchok deleted the gh/swolchok/263/head branch February 18, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/android Trigger Android CI ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants