Deprecate ET_LOG{,_MSG}_AND_RETURN_IF_FALSE

[swolchok]

ET_LOG_MSG_AND_RETURN_IF_FALSE is renamed to ET_CHECK_OR_RETURN_FALSE and moved. ET_LOG_AND_RETURN_FALSE is deprecated in favor of ET_CHECK_OR_RETURN_FALSE with a descriptive message.

[swolchok]

Stack from ghstack (oldest at bottom):

• s/ET_LOG_MSG_AND_RETURN_IF_FALSE/ET_CHECK_OR_RETURN_FALSE #8469
• -> Deprecate ET_LOG{,_MSG}_AND_RETURN_IF_FALSE #8451

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8451

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit a971a5a with merge base 0222074 ():

NEW FAILURE - The following job has failed:

• pull / unittest-arm / linux-job (gh)
  RuntimeError: Command docker exec -t baae3a0d15b1fa2f1883aa77104e5b632b4b8016082bbc2a5f444606dffa011c /exec failed with exit code 1

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / android / run-emulator (gh) (trunk failure)
  The process '/usr/bin/sh' failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[dbort]

Thanks for consolidating these!