Update verifier to handle None Tensor outputs #8235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8235
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0354a91 with merge base e7fd150 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69209059 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Feb 5, 2025
Summary: conv returns (None, Tensor, Tensor) which is uncommon to see since the schema is (Tensor, Tensor, Tensor). This is to test that the verifier just ignores the None return value (since itll be unused in the runtime). Differential Revision: D69209059
JacobSzwejbka
force-pushed
the
export-D69209059
branch
from
ad573bc to
aca1a58
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69209059 |
larryliu0820
approved these changes
Feb 5, 2025
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Feb 5, 2025
Summary: conv returns (None, Tensor, Tensor) which is uncommon to see since the schema is (Tensor, Tensor, Tensor). This is to test that the verifier just ignores the None return value (since itll be unused in the runtime). Reviewed By: larryliu0820 Differential Revision: D69209059
JacobSzwejbka
force-pushed
the
export-D69209059
branch
from
aca1a58 to
dec63f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69209059 |
Summary: conv returns (None, Tensor, Tensor) which is uncommon to see since the schema is (Tensor, Tensor, Tensor). This is to test that the verifier just ignores the None return value (since itll be unused in the runtime). Reviewed By: larryliu0820 Differential Revision: D69209059
JacobSzwejbka
force-pushed
the
export-D69209059
branch
from
dec63f7 to
0354a91
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69209059 |
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: conv returns (None, Tensor, Tensor) which is uncommon to see since the schema is (Tensor, Tensor, Tensor). This is to test that the verifier just ignores the None return value (since itll be unused in the runtime).
Differential Revision: D69209059